0000201: No option to add "reply_to" in the send_email() function

(0000761)
carlos (developer)
2009-03-13 07:48

I realized when you add this option, the old templates would give us the "$email_reply_to not defined" error. What we could do is add a condition to create an empty array if it is not defined. That way we avoid having to add the variable to all of the templates.

    if (!isset($email_reply_to)
    {
       $email_reply_to = array();
    }

    if (isset($options['reply_to']))
    {
        $email_reply_to = array_merge($email_reply_to, $options['reply_to']);
    }
    if(!empty($email_reply_to))
    {
        foreach ($email_reply_to as $address => $name)
        {
            $email->AddReplyTo($address, $name);
        }
    }

(0000762)
james (administrator)
2009-03-13 08:54

Okay that will work.

(0000764)
vcs (reporter)
2009-03-13 10:30

issue#201 Suggested code has been added in order to have the option of setting the "reply_to" value.

Repository: /var/svn/trellis-dev, Revision: 8574, Committer: carlos

(0000852)
carlos (developer)
2009-05-28 12:26

Reminder sent to: james

I believe this could be marked as resolved too. The patch is already applied and it seems to be working fine.

(0001116)
carlos (developer)
2010-05-23 09:34

I am going to mark this as resolved since it has been committed and working fine.

Issue History
Date Modified	Username	Field	Change
2009-03-11 15:50	carlos	New Issue
2009-03-11 15:58	james	Status	new => confirmed
2009-03-11 15:58	james	Status	confirmed => assigned
2009-03-11 15:58	james	Assigned To	=> carlos
2009-03-13 07:48	carlos	Note Added: 0000761
2009-03-13 08:54	james	Note Added: 0000762
2009-03-13 10:30	vcs	Checkin
2009-03-13 10:30	vcs	Note Added: 0000764
2009-05-28 12:26	carlos	Issue Monitored: james
2009-05-28 12:26	carlos	Note Added: 0000852
2010-05-23 09:34	carlos	Note Added: 0001116
2010-05-23 09:34	carlos	Status	assigned => resolution committed
2010-05-23 09:34	carlos	Resolution	open => fixed
2010-05-26 08:08	carlos	Status	resolution committed => confirmed
2010-05-26 08:08	carlos	Resolution	fixed => open

Notes
(0000761) carlos (developer) 2009-03-13 07:48	I realized when you add this option, the old templates would give us the "$email_reply_to not defined" error. What we could do is add a condition to create an empty array if it is not defined. That way we avoid having to add the variable to all of the templates. if (!isset($email_reply_to) { $email_reply_to = array(); } if (isset($options['reply_to'])) { $email_reply_to = array_merge($email_reply_to, $options['reply_to']); } if(!empty($email_reply_to)) { foreach ($email_reply_to as $address => $name) { $email->AddReplyTo($address, $name); } }

(0000762) james (administrator) 2009-03-13 08:54	Okay that will work.

(0000764) vcs (reporter) 2009-03-13 10:30	issue#201 Suggested code has been added in order to have the option of setting the "reply_to" value. Repository: /var/svn/trellis-dev, Revision: 8574, Committer: carlos

(0000852) carlos (developer) 2009-05-28 12:26	Reminder sent to: james I believe this could be marked as resolved too. The patch is already applied and it seems to be working fine.

(0001116) carlos (developer) 2010-05-23 09:34	I am going to mark this as resolved since it has been committed and working fine.

Relationships