Viewing Issue Advanced Details
271 [Trellis] Certificates feature N/A 2010-08-30 13:27 2010-08-30 13:29
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
add support for transparency in images for certificates (and pdfs in general)
Someone wrote an extension to FPDF 1.6 that adds support for alpha-channels in PNGs and JPGs:

http://staff.dasdeck.de/valentin/fpdf/fpdf_alpha/ [^]

In order to facilitate this, Trellis' FPDF class must be upgraded from 1.53 to 1.6.
There are no notes attached to this issue.




Viewing Issue Advanced Details
270 [Trellis] Events minor always 2010-08-27 12:21 2010-08-30 13:29
james  
ryanhorn  
normal  
assigned 0.5.2  
open  
none    
none  
TrellisEventObject_reminder defines the following class properties as private, different than parent
TrellisEventObject_reminder defines the following class properties as private, while its parent class, TrellisEventObject, defines them as protected

$event_id
$db
$parameters

This is illegal in PHP and will cause an error if you try to load the class file...as you can only use a weaker visibility for the same class properties and methods when inheriting.
There are no notes attached to this issue.




Viewing Issue Advanced Details
269 [Trellis] Certificates feature N/A 2010-08-16 23:38 2010-08-16 23:38
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Allow certificate templates to be defined as a client setting
Currently the certificate templates that are displayed when creating a new certificate in the admin tool show all certificates that are certificate template files in the system.

These should have an option to be limited to display only those certificate templates applicable to the client or even community.

Adding a client setting would and a slight modification to check for this setting will allow this.
There are no notes attached to this issue.




Viewing Issue Advanced Details
268 [Trellis] Course Objects feature always 2010-07-14 16:16 2010-08-30 13:30
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
the default behavior when creating a course should be to add that course to the current community
Currently when you create a course in a community you have to explicitly specify to add the course to the current community. The LMS should assume that if you're creating a course in a community, you want the course in that community.

This means in the "Add course to the following communities" area in the create course page, the checkbox for the current community should be checked by default.

Steps to reproduce:
1) Switch to a non-root community and navigate to the create course page.
There are no notes attached to this issue.




Viewing Issue Advanced Details
267 [Trellis] Courses feature N/A 2010-07-01 16:13 2010-08-11 10:17
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
add waitlist support for course and program sections
This will apply to both course sections and program sections. Here is the process outlined:

1) User initiates registration request
2) If section is full, ask user if he wants to be waitlisted
3) Automatically register and notify user once space is available (whether seat limit is increased or users are unregistered)
One table called "waitlist" with the following fields will be added:

insert_timestamp
user_id
section_type (or registration_type)
reference_id


Two client settings will be added:

waitlist_enabled (enables waitlist functionality)
waitlist_user_limit (max number of users that can be waitlisted in a section, defaults to 0 for unlimited)
Notes
(0001129)
vcs   
2010-08-05 16:27   
issue#267 updated code and styling to allow for new content header area in a report header


Repository: /var/svn/trellis-dev, Revision: 8880, Committer: henry
(0001130)
vcs   
2010-08-05 20:51   
issue#267 added support for section waitlists


Repository: /var/svn/trellis-dev, Revision: 8881, Committer: henry
(0001131)
vcs   
2010-08-11 10:17   
issue#267 fixed permission for clearing waitlist


Repository: /var/svn/trellis-dev, Revision: 8882, Committer: henry




Viewing Issue Advanced Details
266 [Trellis] Trellis Core/Base System minor have not tried 2010-06-30 12:51 2010-06-30 12:52
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
crossdomain.xml support
The Trellis request handler should be able to support the XML policy file, crossdomain.xml. This should be handled the same way the reuqest_handler supports favicon.ico and robots.txt
There are no notes attached to this issue.




Viewing Issue Advanced Details
265 [Trellis] AICC minor have not tried 2010-06-30 11:33 2010-06-30 11:34
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
AICC data not being stored properly
Some AICC data elements are not being stored in the LMS properly. core_lesson is a data group that is required by some courses in order to resume where the user last left off. Trellis does not store this information so that it can be retrieved at a later time.
We should store this information in the responses table for the object. We will need methods to store and get this information when putparam and getparam AICC commands are invoked.
There are no notes attached to this issue.




Viewing Issue Advanced Details
264 [Trellis] AICC minor have not tried 2010-06-28 14:08 2010-06-28 14:08
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Bug when AICC data contains Windows new line characters
Currently the AICC class only supports exploding the AICC data using Unix new line characters (\r\n). It also needs to support the case when the AICC data contains Windows (\n) new line characters.
There are no notes attached to this issue.




Viewing Issue Advanced Details
263 [Trellis] Trellis Core/Base System minor have not tried 2010-06-23 11:42 2010-06-23 14:55
james  
ryanhorn  
normal  
assigned 0.5.2  
open  
none    
none  
database schema for documents table is incorrect
The database schema for the documents table has a minor error in it which will prevent the table from being created by the system when adding a new client.

In TrellisDatabaseSchema.php:
$this->client_schema['documents']['indexes']['nonunique']['document_category'] = 'document_category';

should be:
$this->client_schema['documents']['indexes']['nonunique']['document_category_id'] = 'document_category_id';
Notes
(0001121)
ryanhorn   
2010-06-23 14:03   
Reminder sent to: james
Change was made in the schema file. Please confirm.
(0001123)
vcs   
2010-06-23 14:53   
issue 0000263
Fixed database schema for documents table


Repository: /var/svn/trellis-dev, Revision: 8875, Committer: ryan
(0001124)
vcs   
2010-06-23 14:53   
issue 0000263
Fixed database schema for documents table


Repository: /var/svn/trellis-dev, Revision: 8876, Committer: ryan
(0001125)
ryanhorn   
2010-06-23 14:55   
Reminder sent to: james
Changes have been committed to https://kiwi.learning.net/svnrepos/terllis-dev [^] (trunk and branches/0.6)




Viewing Issue Advanced Details
262 [Trellis] Administration/Reports minor always 2010-06-15 17:41 2010-06-21 11:59
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
unable to have more than one autocomplete on a page
The software currently does not support more than one autocomplete on a page. Whatever function you pass as the getTrellisOperations parameter (to the jquery autocomplete object), it will call the function named "getTrellisOperations" and not the function you passed. In this example:

<script type="text/javascript">
    function my_custom_function {//code here}

    $("#element_id").autocomplete(url,{getTrellisOperations:my_custom_function});
</script>

This should result in my_custom_function getting called when the autocomplete object wishes to call getTrellisOperations. Instead, it still calls "getTrellisOperations".
Notes
(0001120)
henry   
2010-06-15 17:56   
(edited on: 2010-06-15 17:57)
This can be resolved by calling the actual function specified in the object parameters instead of directly calling getTrellisOperations. On line 349 of jquery.autocomplete.js change:

var operations = getTrellisOperations(q, $input.id);

to:

var operations = options.getTrellisOperations(q, $input.id);





Viewing Issue Advanced Details
261 [Trellis] Trellis Core/Base System feature N/A 2010-06-09 10:25 2010-06-09 12:42
henry  
henry  
low  
assigned 0.5.2  
open  
none    
none  
rename country "taiwan, province of china" to just "taiwan"
A few users in Taiwan have complained of the designation of Taiwan as a province of China. I would guess most users of the learning center who will need to specify Taiwan as a location will be Taiwanese and hence offended. Although technically precise, this designation is redundant; it does not help to identify Taiwan as a geographic location.
Notes
(0001117)
vcs   
2010-06-09 12:36   
issue#261 changed name of taiwan (0.5)


Repository: /var/svn/trellis-dev, Revision: 8873, Committer: henry
(0001118)
vcs   
2010-06-09 12:36   
issue#261 changed name of taiwan (0.6)


Repository: /var/svn/trellis-dev, Revision: 8874, Committer: henry
(0001119)
henry   
2010-06-09 12:42   
Reminder sent to: james
This is completed and ready for review.




Viewing Issue Advanced Details
260 [Trellis] Trellis Core/Base System minor have not tried 2010-06-04 05:54 2010-06-04 05:54
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
use update_registration when scoring course
The TrellisCourse score_course method currently does not use the update_registration method to make changes to the registration when being scored.

Using the update_registration method will allow better flexibility when creating plugin hooks so that these hooks can be fired upon scoring of the course.
There are no notes attached to this issue.




Viewing Issue Advanced Details
259 [Trellis] Administration/Reports minor always 2010-04-28 14:59 2010-04-28 15:17
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
trying to browse program sections results in sql error
Clicking "Browse Program Sections" in the navigation menu on the left results in a sql error:
Error 31024

SteamDB->select_field(SELECT COUNT(*) FROM ( program_sections prgs, programs prg) LEFT JOIN (SELECT it.reference_id AS program_section_id, u.user_id AS instructor_id, GROUP_CONCAT(DISTINCT CONCAT_WS(' ', u.first_name, u.last_name) SEPARATOR ', ') AS instructor_name FROM users u, instructors it WHERE u.user_id = it.user_id AND instructor_type = 'program_section' GROUP BY reference_id) AS it ON prgs.program_section_id = it.program_section_id LEFT JOIN (SELECT uprg.program_section_id, COUNT(uprg.user_id) AS program_section_users FROM users_programs uprg, users u, users_communities ucm, WHERE uprg.user_id = u.user_id AND u.user_status <> 'disabled' AND u.user_id = ucm.user_id AND ucm.community_id = '5' AND GROUP BY uprg.program_section_id) AS prgs_u ON prgs_u.program_section_id = prgs.program_section_id LEFT JOIN locations l ON prgs.location_id = l.location_id WHERE prgs.program_id = prg.program_id AND prg.community_id = '5' LIMIT 1): the query could not be completed; You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE uprg.user_id = u.user_id AND u.user_status <> 'disabled' AND u.user_id = u' at line 1
In /var/www/trellis_web/0.6/core/global/classes/SteamDB_to_TrellisDB.php on line 443.
Notes
(0001109)
henry   
2010-04-28 15:02   
This happens because of line 1433 in TrellisLMS->get_program_sections(). The SQL query has syntax errors, specifically an extra comma before the WHERE keyword and an extra AND before the GROUP BY keyword.
(0001110)
vcs   
2010-04-28 15:15   
issue#259, debugged sql query in get_program_sections() method (trunk)


Repository: /var/svn/trellis-dev, Revision: 8867, Committer: henry
(0001111)
vcs   
2010-04-28 15:16   
issue#259, debugged sql query in get_program_sections() method (0.6 branch)


Repository: /var/svn/trellis-dev, Revision: 8868, Committer: henry
(0001112)
henry   
2010-04-28 15:17   
Reminder sent to: james
This has been fixed, tested, is working and ready for review.




Viewing Issue Advanced Details
258 [Trellis] Trellis Core/Base System minor always 2010-04-22 18:48 2010-04-22 18:51
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
updating, moving or deleting a group has permission issues
A permission error is thrown if you have access to a group when attempting to update move or delete the group. But if you access to the group in the current community, this error should not be thrown. The update move and remove group methods are always checking the root community (1) for group access. They should check the current community.
Notes
(0001108)
vcs   
2010-04-22 18:51   
issue#258 update the update/delete/move _group methods so that they check the current community for group access permissions


Repository: /var/svn/trellis-dev, Revision: 8866, Committer: james




Viewing Issue Advanced Details
257 [Trellis] Courses minor always 2010-04-22 17:09 2010-04-22 17:22
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
scorm course window not resizable
If you launch a scorm course from the course info page, the window is not resizable. It should be.

This does not happen if you launch the course from anywhere else.
Notes
(0001105)
henry   
2010-04-22 17:10   
(edited on: 2010-04-22 17:12)
This happens because the javascript window.open parameter "resizable" is misspelled "resizeable" in base/modules/courseinfo.php

(0001106)
vcs   
2010-04-22 17:14   
issue#257 fixed misspelled javascript parameter


Repository: /var/svn/trellis-dev, Revision: 8864, Committer: henry
(0001107)
vcs   
2010-04-22 17:22   
issue#257 fixed misspelled javascript parameter (trunk)


Repository: /var/svn/trellis-dev, Revision: 8865, Committer: henry




Viewing Issue Advanced Details
256 [Trellis] Administration/Reports minor have not tried 2010-04-20 10:41 2010-04-20 11:01
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
add start/end dates to course section browser also a date filter
Update the course section browser to include a date range filter
as well as 2 additional columns "start date" and "end date"
Notes
(0001103)
vcs   
2010-04-20 11:01   
issue#256 added start/end date columns and a date range filter for the start and end date fields


Repository: /var/svn/trellis-dev, Revision: 8862, Committer: james




Viewing Issue Advanced Details
255 [Trellis] Administration/Reports minor have not tried 2010-04-20 10:34 2010-04-20 11:27
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
create course section drop-down box for courses truncated
The drop-down box on the create course section admin module truncates longer course titles. Let's expand the width of the select box to fit all course titles.
we'll add a style to set the width to auto
Notes
(0001102)
vcs   
2010-04-20 10:39   
issue#255 updated the styling of the course select field to prevent truncating course titles


Repository: /var/svn/trellis-dev, Revision: 8861, Committer: james
(0001104)
vcs   
2010-04-20 11:27   
issue#255 updated to use the width_flexible css class


Repository: /var/svn/trellis-dev, Revision: 8863, Committer: james




Viewing Issue Advanced Details
254 [Trellis] Courses feature N/A 2010-04-15 09:46 2010-04-15 09:48
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
add a method to add a course unit
The TrellisLMS class is missing a method that allows adding a course unit to a course.

This method should be named "add_course_unit" and allow the following parameters:
course_id
accreditor_id
accreditor_info
Notes
(0001101)
vcs   
2010-04-15 09:48   
issue#254 added the add_course_unit method to the LMS class


Repository: /var/svn/trellis-dev, Revision: 8860, Committer: james




Viewing Issue Advanced Details
253 [Trellis] Courses minor always 2010-04-15 09:23 2010-04-15 09:44
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
an empty accreditor id will return if no course units are assigned
when using the "get_course_units" method in the TrellisLMS class, the accreditor_id field will be empty if the course does not carry any units for that accreditor.

Expected result:
The accreditor id will be populated with the proper value regardless if the course has units for that accreditor.
An update to the query in the get_course_units method is necessary for it to consistently return the accreditor_id
Notes
(0001100)
vcs   
2010-04-15 09:26   
issue#253 updated get_course_units so that the accreditor_id will always be populated regardless if the course has units for a specific accreditor


Repository: /var/svn/trellis-dev, Revision: 8859, Committer: james




Viewing Issue Advanced Details
252 [Trellis] SCORM minor always 2010-04-08 12:32 2010-04-08 12:35
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Error when uploading a SCORM package and resource/file is blank
In the case that the imsmanifest.xml provided with a SCORM package contains a blank resource identifier, the method will throw an exception indicating it can not perform the copy function.

Here is an example of a blank resource node in the imsmanifest.xml:

    <resource identifier="R_111" type="webcontent" adlcp:scormType="asset">
      <file href=""/>
    </resource>
Notes
(0001098)
vcs   
2010-04-08 12:35   
issue#252 error when imsmanfest.xml defines a blank resource - so we'll skip if file to copy is blank


Repository: /var/svn/trellis-dev, Revision: 8857, Committer: james
(0001099)
vcs   
2010-04-08 12:35   
issue#252 error when imsmanfest.xml defines a blank resource - so we'll skip if file to copy is blank


Repository: /var/svn/trellis-dev, Revision: 8858, Committer: james




Viewing Issue Advanced Details
251 [Trellis] Course Objects feature N/A 2010-03-16 17:57 2010-03-22 14:40
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
add feature to only show object results if the package's required score was met
For a test, I want to only show the result of each object if the user passed the test. Right now this is controlled using the "show_result" object parameter. Objects will show their results unless "show_result" is explicitly set to false. The problem with this is it does not differentiate between the package being passed or not, so you can either not show results at all, or you can show it regardless of the user passing. I'd like to show the results only if the package was passed (i.e. had its required score met).
Notes
(0001096)
vcs   
2010-03-22 14:37   
issue#251 modified to only show object result if the package's required score was met at least once


Repository: /var/svn/trellis-dev, Revision: 8854, Committer: henry
(0001097)
vcs   
2010-03-22 14:40   
issue#251 modified to only show object result if the package's required score was met at least once


Repository: /var/svn/trellis-dev, Revision: 8855, Committer: henry




Viewing Issue Advanced Details
250 [Trellis] SCORM minor always 2010-03-10 17:17 2010-05-26 08:09
carlos  
carlos  
normal  
confirmed  
open  
none    
none  
SCORM PIF upload overwrites short description
When a new SCORMPIF course is uploaded to update an existing one, the short description that we originally had is overwritten and gets the value of the original description field. After the upload, both description and short description will have the same value.
Right now, the values that we use to populate those fields come from the database and not from the xml, so when we populate the short description field, we should not use the same value that we use for the description field.
Notes
(0001113)
vcs   
2010-05-06 14:16   
issue#250 Change class so it assigns the course_description_short to the short description field instead of the regular description.


Repository: /var/svn/trellis-dev, Revision: 8869, Committer: carlos




Viewing Issue Advanced Details
249 [Trellis] Modules minor always 2010-03-03 14:43 2010-05-23 08:56
carlos  
carlos  
normal  
assigned  
open  
none    
none  
Error if start time bigger than end time regardless the date
In coursectioninfo, when a course section is edited if the end time is set to an earlier time that the start time, it always shows the error message "The end time must come after start time". In my opinion, this should only be taken into account when the dates are the same. We just need to add a conditional block. I tested a solution and it is working fine.
coursesectioninfo.patch (1 KB) 2010-03-04 10:26
Notes
(0001094)
james   
2010-03-03 17:52   
(edited on: 2010-03-03 17:58)
It should check if the end date/time is before the start date/time. Please provide your patch for this.

(0001095)
carlos   
2010-03-04 10:26   
The patch has been uploaded.
(0001115)
carlos   
2010-05-23 08:56   
Reminder sent to: james
I committed the resolution for this one to dev (trunk). I believe the issue can be closed, but wanted to check with you. By the way, do you prefer me letting you know before closing an issue or if I test should I just go ahead and close it?

Thanks,
Carlos




Viewing Issue Advanced Details
248 [Trellis] General/Other minor have not tried 2010-03-03 14:24 2010-03-03 14:25
carlos  
 
normal  
new  
open  
none    
none  
Repeated error code in trellis_errors
The error code for the errors defined in case that a course section is full and in case that is not empty are duplicated, so the second one is overwriting the first one.
There are no notes attached to this issue.




Viewing Issue Advanced Details
247 [Trellis] Administration/Reports minor always 2009-12-08 15:45 2009-12-14 11:25
henry  
henry  
normal  
invalid 0.5.2  
no change required  
none    
none  
registration browser displays registrations for disabled courses
The registration browser displays registrations for disabled courses when it shouldn't. No information regarding disabled courses should be visible anywhere except when explicitly requested in the course browser.
Notes
(0001065)
henry   
2009-12-08 15:49   
TrellisLMS->get_registrations() should be modified with the addition of "c.course_status <> 'disabled'" in the where clause and TrellisLMS->get_registration() should be modified with an exception thrown if asked to retrieve a registration of a disabled course.
(0001066)
vcs   
2009-12-08 16:14   
issue#247 don't retrieve disabled courses in get registration methods


Repository: /var/svn/trellis-dev, Revision: 8829, Committer: henry
(0001067)
henry   
2009-12-08 16:19   
Reminder sent to: james
This has been tested, is working and is ready for review. Note that I used the error message of the registration not existing instead of permission denied. Should this be changed?
(0001068)
vcs   
2009-12-08 17:10   
issue#247 reverted unnecessary revision 8829


Repository: /var/svn/trellis-dev, Revision: 8830, Committer: henry
(0001069)
henry   
2009-12-08 17:12   
This is an invalid issue and was caused by a customization on the test learning center. The registration browser will properly display status based on the parameters passed to TrellisLMS->get_registrations().

Also we will hold off on preventing get_registration() to retrieve disabled courses.




Viewing Issue Advanced Details
246 [Trellis] Administration/Reports minor have not tried 2009-12-03 11:31 2009-12-03 11:32
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
user program browser export error
When exporting the results from the user program browser report, it produces the following error:
Undefined index: user_program_completed_courses; .../core/global/classes/TrellisExport.php @ line 270;
- login into admin and click on the Browser Program Users link.
- ensure there is data listed
- click the export tab to export the data
- a blank or error exported file is produced

expected result:
the data listed should be contained within the exported file format
in userprogrambrowser.php, user_program_completed_courses should be changed to user_program_complete_courses
Notes
(0001064)
vcs   
2009-12-03 11:32   
issue#246 fixed undefined index when exporting the data from this report


Repository: /var/svn/trellis-dev, Revision: 8828, Committer: james




Viewing Issue Advanced Details
245 [Trellis] Administration/Reports minor have not tried 2009-11-23 16:43 2009-11-23 16:45
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
User Program Browser is retrieving all users regardless of user status
The User Program Browser is retrieving all users regardless of their user status. More specifically this get_users_programs method should be consistent with all other methods and only get only users who do not have a disabled user status.
Notes
(0001063)
vcs   
2009-11-23 16:45   
issue#245 get_users_programs - do not get users who have a disabled user status


Repository: /var/svn/trellis-dev, Revision: 8817, Committer: james




Viewing Issue Advanced Details
244 [Trellis] Administration/Reports minor always 2009-11-17 10:25 2009-11-19 16:49
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
unable to filter by disabled course in userbrowser
When viewing disabled courses in the course browser, clicking on the number of registered users will not show users grouped by that course, as you expect it to, but instead it will list all users. The course is actually missing from the filter group select, which will default to the first choice (without actually applying to the filter).

Steps to reproduce:
1) View disabled courses in the course browser.
2) Click on the number of registered users for a course
3) Observer that you are taken to the user browser page and that the result set is not filtered by that course
Notes
(0001056)
henry   
2009-11-17 10:28   
(edited on: 2009-11-17 10:41)
This happens because the filter grouping excludes courses with "Disabled" status in the user browser. I think either the userbrowser module should be modified to properly filter if given the ID of a disabled course, or the coursebrowser module should not display the filter grouping link for disabled courses.

(0001058)
henry   
2009-11-19 14:16   
I've decided that the course browser should not link to the user browser for disabled courses. The reason being that in no other module other than the course browser is information related to disabled courses visible. This includes user transcripts, the course count for users displayed in the user browser, and the registration browser. To remain consistent with this treatment of disabled courses, there will be no link to the user browser for disabled courses in the course browser. If the user wishes to view additional information he must change the course status to "Inactive" or "Expired".
(0001059)
vcs   
2009-11-19 14:16   
issue#244 only link the course users count to user browser if the course is not disabled


Repository: /var/svn/trellis-dev, Revision: 8813, Committer: henry
(0001061)
vcs   
2009-11-19 15:43   
issue#244 debugged


Repository: /var/svn/trellis-dev, Revision: 8815, Committer: henry
(0001062)
vcs   
2009-11-19 16:49   
issue 0000244 changed method of disabling course users count link for disabled courses


Repository: /var/svn/trellis-dev, Revision: 8816, Committer: henry




Viewing Issue Advanced Details
243 [Trellis] Document Management System feature N/A 2009-10-22 13:34 2009-12-28 14:49
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
add document categories module to administration interface
Document categories are currently set in the client_config.php file which must be updated manually by editing that file. A "Document Categories" module should be added to facilitate dynamic manipulation of categories by learning center administrators.

It's proposed to add a "document_categories" table linked to the "documents" table through a "document_category_id" primary key. A category can also have communities specified to which it should be added.

New permissions entitled "view_document_categories", "delete_document_categories", "edit_document_categories" and "add_document_categories" will also be added.
Notes
(0001021)
vcs   
2009-10-22 15:14   
issue#243 added document_categories table structure


Repository: /var/svn/trellis-dev, Revision: 8779, Committer: henry
(0001022)
vcs   
2009-10-22 15:21   
issue#243 changed documents_category field in documents table to documents_category_id, also made document_category_id in document_categories table auto increment


Repository: /var/svn/trellis-dev, Revision: 8780, Committer: henry
(0001023)
vcs   
2009-10-22 15:56   
issue#243 added permissions for document_categories


Repository: /var/svn/trellis-dev, Revision: 8781, Committer: henry
(0001024)
vcs   
2009-10-22 16:48   
issue#243 added document category errors


Repository: /var/svn/trellis-dev, Revision: 8782, Committer: henry
(0001025)
vcs   
2009-10-22 17:25   
issue#243 added document category methods to trellisdms class


Repository: /var/svn/trellis-dev, Revision: 8783, Committer: henry
(0001026)
vcs   
2009-10-23 11:18   
issue#243 added document categories mod to the navigation/mod menu


Repository: /var/svn/trellis-dev, Revision: 8784, Committer: henry
(0001027)
vcs   
2009-10-23 11:21   
issue#243 changed position, debugged


Repository: /var/svn/trellis-dev, Revision: 8785, Committer: henry
(0001028)
vcs   
2009-10-23 11:25   
issue#243 added ad_document_categories uri


Repository: /var/svn/trellis-dev, Revision: 8786, Committer: henry
(0001029)
vcs   
2009-10-23 12:01   
issue#243 debugged typo


Repository: /var/svn/trellis-dev, Revision: 8787, Committer: henry
(0001032)
vcs   
2009-10-23 17:13   
issue#243 added get_document_category method


Repository: /var/svn/trellis-dev, Revision: 8788, Committer: henry
(0001033)
vcs   
2009-10-27 09:17   
issue#243 added document_category_id paramater to filter by document_category_id


Repository: /var/svn/trellis-dev, Revision: 8789, Committer: henry
(0001034)
vcs   
2009-10-27 09:19   
issue#243 added document_categories to get_ids method


Repository: /var/svn/trellis-dev, Revision: 8790, Committer: henry
(0001035)
vcs   
2009-10-27 09:23   
issue#243 updated documents modules and snippets to utilize new document categories


Repository: /var/svn/trellis-dev, Revision: 8791, Committer: henry
(0001036)
vcs   
2009-10-27 09:24   
issue#243 added document categories module and snippet


Repository: /var/svn/trellis-dev, Revision: 8792, Committer: henry
(0001037)
vcs   
2009-10-27 09:34   
issue#243 added document_category_id paramater to filter by document_category_id to get_user_documents method


Repository: /var/svn/trellis-dev, Revision: 8793, Committer: henry
(0001038)
vcs   
2009-10-27 09:37   
issue#243 updated base documents module to utilize new document categories


Repository: /var/svn/trellis-dev, Revision: 8794, Committer: henry
(0001040)
vcs   
2009-10-27 12:24   
issue#243 debugged field_name


Repository: /var/svn/trellis-dev, Revision: 8796, Committer: henry
(0001045)
vcs   
2009-10-29 13:06   
issue#243 minor update to line placement of code


Repository: /var/svn/trellis-dev, Revision: 8800, Committer: henry
(0001046)
vcs   
2009-10-29 13:15   
issue#243 added permission restrictions


Repository: /var/svn/trellis-dev, Revision: 8801, Committer: henry
(0001047)
vcs   
2009-10-29 13:17   
issue#243 debugged


Repository: /var/svn/trellis-dev, Revision: 8802, Committer: henry
(0001073)
vcs   
2009-12-22 14:17   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001074)
vcs   
2009-12-22 14:32   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001075)
vcs   
2009-12-22 14:47   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001076)
vcs   
2009-12-22 14:56   
issue#243 removed no longer used $TRELLIS_document_categories variable from client_config template


Repository: /var/svn/trellis-dev, Revision: 8837, Committer: henry
(0001077)
vcs   
2009-12-22 15:02   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001078)
vcs   
2009-12-22 15:11   
issue#243 removed no longer used $TRELLIS_document_categories variable from client_config template


Repository: /var/svn/trellis-dev, Revision: 8837, Committer: henry
(0001079)
vcs   
2009-12-22 15:17   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001080)
vcs   
2009-12-22 15:26   
issue#243 removed no longer used $TRELLIS_document_categories variable from client_config template


Repository: /var/svn/trellis-dev, Revision: 8837, Committer: henry
(0001081)
vcs   
2009-12-22 15:32   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001082)
vcs   
2009-12-22 15:56   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001083)
vcs   
2009-12-22 15:58   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001084)
vcs   
2009-12-22 16:01   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001085)
vcs   
2009-12-22 16:05   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001086)
vcs   
2009-12-22 16:38   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001087)
vcs   
2009-12-22 16:39   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001088)
vcs   
2009-12-22 16:40   
issue#243 added "none" option for a document's category

Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001089)
vcs   
2009-12-22 16:44   
issue#243 added "none" option for a document's category


Repository: /var/svn/trellis-dev, Revision: 8836, Committer: henry
(0001090)
vcs   
2009-12-23 11:07   
issue#243 added default document category "General" to root and new communities


Repository: /var/svn/trellis-dev, Revision: 8838, Committer: henry
(0001091)
vcs   
2009-12-23 11:36   
issue#243 cosmetic fix to whitespace


Repository: /var/svn/trellis-dev, Revision: 8840, Committer: henry
(0001092)
henry   
2009-12-28 14:49   
issue#243 added "none" option for a document's category when uploading document


Repository: /var/svn/trellis-dev, Revision: 8841, Committer: henry




Viewing Issue Advanced Details
242 [Trellis] Trellis Core/Base System minor always 2009-09-28 17:11 2009-09-28 17:18
henry  
 
normal  
new 0.5.2  
open  
none    
none  
email altbody is missing assignments when using the send_email() function
Currently the altbody in an email template will not have its variable assignments assigned (e.g. {$username} will not be replaced with the proper value) if you send the email using the send_email() function. The altbody's assignments should be properly assigned.

Note that the normal body itself will have its assignments properly assigned.

Steps to reproduce:
1) Declare $email_alt_body in an email template and put assignments in it.
2) Declare a new template object, set corresponding assignments, and pass it to the send_email() function along with the email template and your user ID.
3) Receive the email and note the lack of assignment in the message source.
Notes
(0001014)
henry   
2009-09-28 17:18   
This happens because the altbody is built using the same template object that was used to build the body. The same object cannot be used because the build method can only be called once because it clears its assignments after being called. Instead, a clone should be made of the template object and the altbody should be built from that clone.




Viewing Issue Advanced Details
241 [Trellis] Courses minor N/A 2009-09-21 14:51 2009-09-21 17:39
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
expired courses should be able to be reviewed if completed
Currently, a user cannot review an expired course that he has completed. A user should be able to do this. He will still not be able to register for an expired course nor will he be able to complete it if he hasn't.
Notes
(0001010)
vcs   
2009-09-21 15:20   
issue#241 show expired courses in completed transcript only


Repository: /var/svn/trellis-dev, Revision: 8756, Committer: henry
(0001012)
vcs   
2009-09-21 16:53   
issue#241 allow expired courses to be reviewed if the registration status is complete, passed or failed


Repository: /var/svn/trellis-dev, Revision: 8757, Committer: henry
(0001013)
henry   
2009-09-21 17:39   
Reminder sent to: james
This has been completed and is ready for review.




Viewing Issue Advanced Details
240 [Trellis] Trellis Core/Base System minor N/A 2009-09-18 16:37 2009-09-21 15:25
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
change default character set for the database to utf8
Currently the default character set for the database is latin1. It should be changed to utf8 in order to extend support for different languages.
Notes
(0001011)
james   
2009-09-21 15:25   
we will need to change this within the trellis database schema class.




Viewing Issue Advanced Details
239 [Trellis] Certificates minor always 2009-09-01 17:09 2009-09-08 10:51
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
certificate prematurely awarded upon completion of one out of multiple requirements
For a certificate with more than one requirement, the certificate is awarding upon completion of only one of those requirements. The certificate should only award upon completion of all requirements.

Steps to reproduce:
1) Create a certificate with more than one requirement
2) Complete one requirement only (other requirements left incomplete)
3) See that you have been awarded the certificate
Notes
(0000994)
henry   
2009-09-01 17:22   
This occurs due to a logical error in the TrellisCourse->check_certificate_completion() method. In the switch statement for the requirement type, it should "continue 3" instead of "continue 2" (One of the continues applies to the switch statement). In other words, if a requirement is not met, skip awarding of current certificate and check the next certificate.
(0000995)
vcs   
2009-09-01 17:25   
issue#239 debugged check_certificate_completion method


Repository: /var/svn/trellis-dev, Revision: 8741, Committer: henry




Viewing Issue Advanced Details
238 [Trellis] Administration/Reports feature N/A 2009-08-21 14:05 2009-08-26 18:28
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Update the packageresponses report to show answer-level choices
Update the packageresponses report to show which answer the user chose for each object.
We also want to include a column for the xml_object_id as this will be helpful in determining the questions based on the id.
Notes
(0000983)
vcs   
2009-08-21 14:07   
issue#238 added xml_object_id column to package responses


Repository: /var/svn/trellis-dev, Revision: 8732, Committer: james
(0000984)
vcs   
2009-08-26 18:28   
issue#238 updated some interaction course objects to display results on the packageresponses report


Repository: /var/svn/trellis-dev, Revision: 8733, Committer: james




Viewing Issue Advanced Details
237 [Trellis] Events feature N/A 2009-08-04 17:44 2009-08-04 17:50
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
complete code for reminder event object
This event finds all registrations that have not been completed within a parameter-set length of time and sends an e-mail to each user with the list of courses he has not completed.

Currently this object is incomplete and unusable.
There are no notes attached to this issue.




Viewing Issue Advanced Details
236 [Trellis] Learning Center minor always 2009-07-24 10:07 2009-07-24 10:31
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
invalid link to learning center in welcome email
I create a user in the learning center and when he receives the email, the link to the learning center is http:///home. [^] The link should be a valid link to the correct learning center.

Steps to reproduce:
1) Find a learning center which defines the EMAIL_WELCOME constant to core/global/templates/welcome.email (in other words, the default)
2) Create a new user and send him the welcome email.
Notes
(0000966)
henry   
2009-07-24 10:10   
I'm not sure if this is a bug, or if it is an issue that simply requires client customization. In welcome.email, the links is http://{$link}. [^] And in TrellisLMS->create_user(), it inserts into 'link' get_uri('lc_home'), which will return just the module name. It seems to me it should be inserting $_SERVER['HTTP_HOST'] . get_uri('lc_home') into 'link' instead.
(0000967)
vcs   
2009-07-24 10:27   
issue#236 changed the link to the learning center in the welcome email to be the Host: header instead of just the home module


Repository: /var/svn/trellis-dev, Revision: 8719, Committer: henry
(0000969)
henry   
2009-07-24 10:31   
Reminder sent to: james
This has been tested, is working and is ready for review.




Viewing Issue Advanced Details
235 [Trellis] Courses minor always 2009-07-21 17:02 2009-08-31 17:00
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
completion of SCORM course not checking certificate completion
I have a SCORM course and a certificate for which the requirement is the course. After passing the SCORM course, the certificate is not rewarded as it should be.

Steps to reproduce:
1) Upload a SCORM course with a single content organization consisting of a single Item element/node.
2) Create a certificate whose sole requirement is the SCORM course
3) Launch and pass the SCORM course (the SCO must send cmi.completion_status='completed' and/or cmi.success_status='passed')
4) Check that your registration status is 'passed' and note that the certificate was not awarded.
Notes
(0000957)
henry   
2009-07-21 17:05   
(edited on: 2009-07-21 17:06)
To resolve this issue, code to check the certificate completion should be added to the TrellisSCORM->score_course() method where the main conditional evaluates to true.

Note that this bug does not occur if there is more than one Item element/node specified in the content organizations because in this case, responsibility for managing the registration is given to the TrellisCourse class (instead of TrellisSCORM), which properly checks certificate completion.

(0000958)
henry   
2009-07-21 17:40   
Another way to resolve this issue, which seems to me to be the preferred solution, is to always use TrellisCourse to manage the registration regardless of the number of Items (which TrellisSCORM translates into course SCO objects). This would require further development for the TrellisSCORM API -- for example, proper use of the adlcp:completionThreshold element should be made when parsing the manifest, which it currently does not (it sets it to '0').
(0000959)
james   
2009-07-21 20:44   
It is preferred to called $course->score_course from the score_course method in the TrellisSCORM class each time.
(0000960)
vcs   
2009-07-22 17:15   
issue#235 scoring now handled exclusively by the TrellisCourse class


Repository: /var/svn/trellis-dev, Revision: 8714, Committer: henry
(0000961)
henry   
2009-07-22 17:53   
Note on revision 8714:

Updating the score and registration in the TrellisSCORM->score_course() method when there is only one object and package was removed due to redundancy. The score and registration status will still properly be set.
(0000979)
vcs   
2009-08-12 17:26   
issue#235 instantiated $auth which is needed by TrellisCourse->load_registration()


Repository: /var/svn/trellis-dev, Revision: 8729, Committer: henry
(0000980)
vcs   
2009-08-12 17:39   
issue#235 debugged -- TrellisCourse->load_registration() only takes one argument


Repository: /var/svn/trellis-dev, Revision: 8730, Committer: henry
(0000982)
vcs   
2009-08-20 16:28   
issue#235 only score the course if success_status is known or completion_status is set to completed


Repository: /var/svn/trellis-dev, Revision: 8731, Committer: henry
(0000991)
vcs   
2009-08-31 16:56   
issue#235 debugged SCORM 1.2 js/php api


Repository: /var/svn/trellis-dev, Revision: 8740, Committer: henry
(0000993)
henry   
2009-08-31 17:00   
(edited on: 2009-08-31 17:01)
Previous note should be deleted. The log message was supposed to be (and has been corrected) for issue 234 not 235.





Viewing Issue Advanced Details
234 [Trellis] SCORM minor have not tried 2009-07-20 10:28 2010-07-19 14:38
james  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
add SCORM 1.2 support
Add SCORM 1.2 into Trellis. When uploading a SCORM package, the version of the package should be identified in the imsmanifest.xml.

Trellis should store the version of the package so that the proper SCORM API can be used.
Notes
(0000956)
vcs   
2009-07-20 10:32   
issue#234 added SCORM 1.2 js/php api


Repository: /var/svn/trellis-dev, Revision: 8713, Committer: james
(0000992)
henry   
2009-08-31 16:57   
(edited on: 2009-08-31 16:58)
issue#234 debugged SCORM 1.2 js/php api


Repository: /var/svn/trellis-dev, Revision: 8740, Committer: henry

(0000996)
vcs   
2009-09-14 16:13   
issue#234 created and accommodated two different classes for version 1.2 and 2004


Repository: /var/svn/trellis-dev, Revision: 8742, Committer: henry
(0000997)
vcs   
2009-09-14 16:51   
issue#234 debugged method visibility


Repository: /var/svn/trellis-dev, Revision: 8743, Committer: henry
(0000998)
vcs   
2009-09-14 16:52   
issue#234 debugged method visibility


Repository: /var/svn/trellis-dev, Revision: 8744, Committer: henry
(0000999)
vcs   
2009-09-14 17:39   
issue#234 debugged visibility


Repository: /var/svn/trellis-dev, Revision: 8745, Committer: henry
(0001000)
vcs   
2009-09-14 17:39   
issue#234 debugged


Repository: /var/svn/trellis-dev, Revision: 8746, Committer: henry
(0001003)
vcs   
2009-09-16 12:01   
issue#234 debugged


Repository: /var/svn/trellis-dev, Revision: 8749, Committer: henry
(0001004)
vcs   
2009-09-16 12:57   
issue#234 added ims meta-data title and description and set it to course title and description if set


Repository: /var/svn/trellis-dev, Revision: 8750, Committer: henry
(0001005)
vcs   
2009-09-17 16:06   
issue#234 moved trellisscorm->upload_pif to lms class, removed trellisscorm->get_version method


Repository: /var/svn/trellis-dev, Revision: 8751, Committer: henry
(0001006)
vcs   
2009-09-17 16:10   
issue#234 debugged parsing of objectives data element in scorm 1.2 js/php api


Repository: /var/svn/trellis-dev, Revision: 8752, Committer: henry
(0001007)
vcs   
2009-09-18 12:52   
issue#234 accounted for imsmd title, description and langstring not being prefixed with a namespace


Repository: /var/svn/trellis-dev, Revision: 8753, Committer: henry
(0001008)
vcs   
2009-09-18 13:00   
issue#234 course title and description should be updated from manifest when uploading to an existing scorm course


Repository: /var/svn/trellis-dev, Revision: 8754, Committer: henry
(0001009)
vcs   
2009-09-18 13:17   
issue#234 debugged how resource base is set


Repository: /var/svn/trellis-dev, Revision: 8755, Committer: henry
(0001041)
vcs   
2009-10-29 09:40   
issue#234 added missing '?>' to scorm class files


Repository: /var/svn/trellis-dev, Revision: 8797, Committer: henry
(0001126)
vcs   
2010-07-19 14:38   
issue 0000234 debugged call to time conversion method (trunk)


Repository: /var/svn/trellis-dev, Revision: 8877, Committer: henry
(0001127)
vcs   
2010-07-19 14:38   
issue 0000234 debugged call to time conversion method (0.6 branch)


Repository: /var/svn/trellis-dev, Revision: 8878, Committer: henry




Viewing Issue Advanced Details
233 [Trellis] Learning Center minor always 2009-07-13 14:08 2009-07-21 20:45
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
error when trying to filter documents by category
In the documents module in the learning center, I want to filter the documents by its category using the category drop-down. When I do select a category, I receive the error "The search text is not valid" and no documents are listed. I should not receive this error and the selected document category should filter the results properly regardless of whether I enter search text or not.

Steps to reproduce:

1) Visit the documents page in the learning center.
2) Select a category to filter by in the drop-down.
3) Receive the error.
There are no notes attached to this issue.




Viewing Issue Advanced Details
232 [Trellis] Trellis Core/Base System minor always 2009-06-26 12:41 2009-06-26 15:56
james  
carlos  
normal  
assigned 0.5.2  
open  
none    
none  
allow the resource gopher to handle upper case extensions
Currently if a static file has an upper case extension, the correct mime type will not be recognized for the file. This is because the resource gopher only expects a lower case extension to match with the mime type.
1. create an html file with an upper case extension of HTML
2. place the .HTML file in the client's static data directory
3. access the .HTML file via a web browser

Result:
The file will display as plain text

Expected Result:
The file will display as an html page
Notes
(0000947)
vcs   
2009-06-26 15:56   
issue#232 Changed pattern so it is not case sensitive.


Repository: /var/svn/trellis-dev, Revision: 8705, Committer: carlos




Viewing Issue Advanced Details
231 [Trellis] Administration/Reports minor always 2009-06-18 16:36 2009-07-23 05:34
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Open Seat count on new registration page for course/program section not always accurate
If an administer is in a group and attempts to register or transfer a user for a course or program section, they see the Open Seat column for that particular section. This number shows the count of open seats available if the section has a maximum seat number set.

The count has the possibility to be incorrect because it is based on the number of users registered for the section that the current admin has access to (i.e. only users in groups that fall below them in the hierarchy). This should show the true number of open seats for all users in the current community regardless if the admin has access to them or not.
Notes
(0000936)
vcs   
2009-06-23 19:36   
issue#231 fixed open seat count when admin was in a group; made open seats column sortable


Repository: /var/svn/trellis-dev, Revision: 8694, Committer: james
(0000937)
vcs   
2009-06-23 19:41   
issue#231 removed unnecessary code for available seats


Repository: /var/svn/trellis-dev, Revision: 8695, Committer: james
(0000938)
vcs   
2009-06-23 19:47   
issue#231 available_seats debug


Repository: /var/svn/trellis-dev, Revision: 8696, Committer: james
(0000962)
vcs   
2009-07-23 05:34   
issue#231 fixed blank available seats from showing up


Repository: /var/svn/trellis-dev, Revision: 8715, Committer: james




Viewing Issue Advanced Details
230 [Trellis] Administration/Reports minor always 2009-06-05 15:34 2009-06-05 16:39
henry  
henry  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
courses can be deleted despite having a catalog dependency
In the catalog info page for a catalog, the statistics show that there are 17 courses in the catalog. However, clicking on this link (which links to the course browser grouped by this catalog) and filtering by "Show All" (to include disabled courses) shows 16 instead of 17 courses. In other words, there is a missing/ghost course.

Investigation has revealed that it is possible to delete a course that is currently in a catalog, leaving an orphan row linking the no longer existing course to the catalog. You should not be able to delete a course that still has such a dependency.

Steps to reproduce:
1) Add a course to a catalog
2) Delete the course
3) Check the list of courses in the catalog and see that the catalog still is linked to the course
Notes
(0000902)
henry   
2009-06-05 15:48   
Or an alternative course of action is to simply fix it to delete the course from the catalog, instead of stopping the user and forcing him to remove it from the catalog first.
(0000903)
james   
2009-06-05 16:11   
let's prevent the course from being deleted if it belongs in a catalog
(0000904)
vcs   
2009-06-05 16:31   
issue 0000230 prevent course from being deleted if it belongs in a catalog


Repository: /var/svn/trellis-dev, Revision: 8664, Committer: henry
(0000905)
henry   
2009-06-05 16:34   
Reminder sent to: james
This has been tested, is working and is ready for review.
(0000907)
vcs   
2009-06-05 16:39   
issue#230 prevent course from being deleted if it belongs in a catalog


Repository: /var/svn/trellis, Revision: 127, Committer: james




Viewing Issue Advanced Details
229 [Trellis] Administration/Reports feature N/A 2009-06-04 14:53 2009-06-04 14:57
henry  
 
normal  
new 0.5.2  
open  
none    
none  
add ability for client administrator to add custom fields and customize administration reports
I think the ability for a client administrator to add/remove custom fields (only for certain tables) and choose what columns to display in administration reports would be a useful feature.

Two or three interfaces (to manage custom fields and choose/arrange columns in a report) and one or two tables would need to be created, and parts of the templater class would be to be modified/rewritten.
There are no notes attached to this issue.




Viewing Issue Advanced Details
228 [Trellis] Administration/Reports minor always 2009-06-03 15:03 2009-06-03 15:16
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
Course progress page incorrectly groups voided package results
On the course progress page for a specific package the results are shown for each attempt the user has submitted for the package. The packages are grouped by the attempt count. This is an issue when attempts are voided. This results in duplicate attempt counts if the user attempts the package again.

We should distinguish the difference between these attempts by using the attempt count along with the attempt seed. This will group the report by attempt more effectively.
We will update the TrellisCourse->get_package_results method to take in an attempt seed as a parameter

Then fix the courseprogress report module to take advantage of this attempt_seed
Notes
(0000893)
vcs   
2009-06-03 15:07   
issue#228 fixed course progress page from incorrectly groups voided package results


Repository: /var/svn/trellis, Revision: 126, Committer: james
(0000894)
vcs   
2009-06-03 15:16   
issue#228 fixed course progress page from incorrectly groups voided package results


Repository: /var/svn/trellis-dev, Revision: 8659, Committer: james




Viewing Issue Advanced Details
227 [Trellis] Trellis Core/Base System feature N/A 2009-06-02 17:25 2009-06-02 17:26
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
add a function that will format a datetime into a human readable elapsed string
Elapsed formated datetimes will result in a time format like:
3 minutes ago
1 week ago
5 years ago

it should be capable of returning a formatted string in the following units:
seconds
minutes
hours
days
weeks
months
years

Also a maximum unit and value should be able to be set. If the max value is reached, then it will return an alternative format (i.e. June 2, 2009). The max unit is the largest unit that will be returned.
Notes
(0000882)
vcs   
2009-06-02 17:26   
issue#227 added format_time_elapsed function that formats a datetime into a human readable elapsed time format


Repository: /var/svn/trellis-dev, Revision: 8651, Committer: james




Viewing Issue Advanced Details
226 [Trellis] Trellis Core/Base System feature N/A 2009-06-01 04:42 2009-06-25 08:01
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Add Discussion feature
add a discussion feature that will initially be used for course contributors to discuss course development on the course information page. This will help course contributors to collaborate and manage development by discussing and sharing ideas in Trellis. This is part of a larger feature to bring better course management to Trellis. Discussion will not be limited to course management, so we will need to account for different discussion types.
Tables:
discussions: discussion_id, discussion_title, discussion_type, reference_id, comment_count, last_comment_date
discussion_comments: discussion_comment_id, discussion_id, user_id, comment_date datetime, comment_text, parent_comment_id, reply_count
Notes
(0000867)
vcs   
2009-06-02 01:03   
issue#226 added TrellisDiscussion class


Repository: /var/svn/trellis-dev, Revision: 8640, Committer: james
(0000868)
vcs   
2009-06-02 01:21   
issue#226 fixed utilities parameter in construct method


Repository: /var/svn/trellis-dev, Revision: 8641, Committer: james
(0000869)
vcs   
2009-06-02 01:26   
issue#226 added skip_count property


Repository: /var/svn/trellis-dev, Revision: 8642, Committer: james
(0000870)
vcs   
2009-06-02 01:47   
issue#226 added discussion to database schema and fixed some table aliases/names


Repository: /var/svn/trellis-dev, Revision: 8643, Committer: james
(0000871)
vcs   
2009-06-02 01:50   
issue#226 fixed discussions table index in schema


Repository: /var/svn/trellis-dev, Revision: 8644, Committer: james
(0000942)
vcs   
2009-06-25 07:33   
issue#226 fixed line breaks in discussion text


Repository: /var/svn/trellis-dev, Revision: 8700, Committer: james
(0000944)
vcs   
2009-06-25 08:01   
issue#226 updated javascript when replying to a comment


Repository: /var/svn/trellis-dev, Revision: 8702, Committer: james




Viewing Issue Advanced Details
225 [Trellis] Administration/Reports minor always 2009-05-27 11:03 2009-06-02 13:13
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
TSV exported file not correctly formatted
When the data in a browser is exported to TSV, the resulting file is incorrectly formatted. Some columns are separated by a comma instead of a tab.

This applies to and can be reproduced in any browser.
There are no notes attached to this issue.




Viewing Issue Advanced Details
224 [Trellis] Trellis Core/Base System minor always 2009-05-26 10:48 2009-05-26 11:33
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
remove program completion date when an incompleted course is added to a program
if a program is complete by the learner and an admin adds a brand new course to the program, the program completion date be removed in addition to setting the program status to incomplete. currently the completion date is left even though the program is incomplete. let's be consistent and remove the completion date as well since the program is no longer completed.
Notes
(0000849)
vcs   
2009-05-26 11:31   
issue#224 remove the completion when setting a user_program to incomplete


Repository: /var/svn/trellis-dev, Revision: 8631, Committer: james
(0000850)
vcs   
2009-05-26 11:33   
issue#224 remove the completion date when setting a user_program to incomplete


Repository: /var/svn/trellis, Revision: 122, Committer: james




Viewing Issue Advanced Details
223 [Trellis] Administration/Reports feature N/A 2009-05-22 12:54 2009-06-03 13:29
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
show admin logo on admin login screen
Update the Admin/Reports login page by showing the admin logo above the login form.
Notes
(0000848)
vcs   
2009-05-22 13:27   
issue#223 added client logo to admin login screen


Repository: /var/svn/trellis-dev, Revision: 8630, Committer: james
(0000887)
vcs   
2009-06-03 13:29   
issue#223 added client logo to admin login screen


Repository: /var/svn/trellis, Revision: 123, Committer: james




Viewing Issue Advanced Details
222 [Trellis] Administration/Reports trivial always 2009-05-20 17:03 2009-05-20 17:52
henry  
henry  
low  
assigned 0.5.2  
open  
none    
none  
inconsistent sort of name column across browsers
The "Name" column sorts by first name for the Registration and Certification Browsers, but by last name for the User Browser. I think consistency should be maintained by changing Registration and Certification Browser to sort by last name.
Notes
(0000846)
vcs   
2009-05-20 17:51   
issue#222

updated to sort name column using last_name, first_name


Repository: /var/svn/trellis-dev, Revision: 8629, Committer: henry
(0000847)
henry   
2009-05-20 17:52   
Reminder sent to: james
This has been tested, is working and is ready for review.




Viewing Issue Advanced Details
221 [Trellis] Administration/Reports minor always 2009-05-19 18:25 2009-12-14 16:19
henry  
henry  
normal  
assigned 0.5.2  
reopened  
none    
none  
export row count not matching browser row count when a filter is applied
In the User Certificates Browser, I applied a filter that returned 1058 results. I exported those results and the file contained over 1500 results. The export file should contain the same number of results as the browser.

This bug applies to all browsers, and two conditions must be present for this bug to occur:

1) The result set must exceed TRELLIS_EXPORT_ROWS_PER_QUERY.
2) A filter must be applied.

Steps to reproduce:

1) Visit any browser and apply a filter which results in a row count that exceeds TRELLIS_EXPORT_ROWS_PER_QUERY.
2) Export the results.
3) Note the discrepancy in the row count of the exported file.
layout_functions.php.patch (0 KB) 2009-05-19 18:49
regbrowser.php.patch (2 KB) 2009-11-06 06:17
regbrowser.php (10 KB) 2009-06-02 14:51
Notes
(0000842)
henry   
2009-05-19 18:48   
I've attached a patch to layout_functions.php that fixes this bug.

Short Explanation:
This occurs because export_data_table() uses more than one query to obtain the data set when the row count exceeds TRELLIS_EXPORT_ROWS_PER_QUERY, and the filters only get applied to the first query. My patch saves the filters and applies them to all subsequent queries.

Long Explanation:
The export_data_table() function divides the database query into parts equal to the row count divided by TRELLIS_EXPORT_ROWS_PER_QUERY, rounded up. For example, if the row count is 1400 and TRELLIS_EXPORT_ROWS_PER_QUERY is equal to 500, export_data_table() will obtain the data set using 3 queries (1400/500 rounded up). Because the query parts used to build the query get reset after every call, export_data_table() saves the parts into a variable called $query_parts and restores it for every subsequent query call. The filters, however, don't make it into query parts until after $query_parts is set, so the filters don't get saved and aren't applied to queries after the first.
(0000843)
vcs   
2009-05-20 10:30   
issue#221

saved and applied filters to subsequent queries in the export_data_table function



Repository: /var/svn/trellis-dev, Revision: 8628, Committer: henry
(0000844)
henry   
2009-05-20 10:31   
Reminder sent to: james
This has been tested, is working and is ready for review.
(0000845)
vcs   
2009-05-20 10:47   
issue#221 saved and applied filters to subsequent queries in the export_data_table function


Repository: /var/svn/trellis, Revision: 121, Committer: james
(0000860)
henry   
2009-05-29 15:39   
Further use and investigation has revealed that the fix I applied does not properly resolve the issue. Specifically, saving and setting utilities->filters before the lms->get() method is incomplete because some lms->get() methods call utilities->add_filters(), and in that method the value of utilities->filters gets set anew from utilities->added_filters, thus overwriting the previously saved utilities->filters.

One possible solution is to save utilities->added_filters instead in export_data_table(), because calling utilities->add_filter() won't overwrite what's in utilities->added_filters, but this would require also calling utilities->update_filters() to save the contents of utilities->added_filters to utilities->filters. The problem with this is that utilities->update_filters() is not a public method.

Another possible solution is to alter the admin modules so that the filters are added inside the get_data_rows() function, so that when exporting the data set, the filters are guaranteed to be added to each query call because export_data_table() uses the get_data_rows() function. Also, the adding of filters in these modules is necessarily tied to the get_data_rows() function, meaning that in these modules, the filters only apply with respect to get_data_rows().

The second solution seems best to me right now. What do you think?
(0000861)
henry   
2009-05-29 15:41   
By the way, to reproduce and see this problem, use the registration browser, apply a filter and export a result set that exceeds TRELLIS_EXPORT_ROWS_PER_QUERY.
(0000862)
james   
2009-05-29 16:28   
(edited on: 2009-05-29 16:29)
Can you attach a patch of altering the regbrowser as an example?

(0000863)
henry   
2009-05-29 16:55   
A patch to regbrowser.php has been attached.
(0000864)
henry   
2009-05-29 17:02   
Or, did you want me to commit a patched regbrowser?
(0000876)
james   
2009-06-02 13:09   
can you attach your patched regbrowser.php file? I can't seem to apply the patch
(0000880)
henry   
2009-06-02 14:51   
A patched regbrowser.php has been attached.
(0000881)
james   
2009-06-02 15:09   
this solution looks like it will work fine, please apply those updates
(0000908)
vcs   
2009-06-05 18:37   
issue#221 reverted revision 8628 which does not properly resolve the issue


Repository: /var/svn/trellis-dev, Revision: 8666, Committer: henry
(0000909)
vcs   
2009-06-05 18:43   
issue#221 moved filters inside the get_data_rows() function


Repository: /var/svn/trellis-dev, Revision: 8667, Committer: henry
(0000910)
henry   
2009-06-05 18:46   
(edited on: 2009-06-05 18:47)
Note that all custom declarations of get_data_rows() inside .client files will need to be updated with the filters from the trunk file. This applies to all browsers.

(0000915)
vcs   
2009-06-08 09:16   
issue#221 added location_id parameter to lms->get_courses()


Repository: /var/svn/trellis-dev, Revision: 8672, Committer: henry
(0000916)
henry   
2009-06-08 09:17   
Regarding revision 8672, coursebrowser.php was adding a location_id filter in get_data_rows(). I changed it to be a lms->get_courses() parameter instead.
(0000930)
vcs   
2009-06-16 12:43   
issue#221 moved filter adding to customizable function filter_data_rows()


Repository: /var/svn/trellis-dev, Revision: 8684, Committer: henry
(0000946)
vcs   
2009-06-26 15:21   
issue#221 added support for client_data_rows() custom function


Repository: /var/svn/trellis-dev, Revision: 8704, Committer: henry
(0000948)
henry   
2009-06-26 16:06   
I've modified the way get_data_rows() works in regbrowser in the following ways:

1) Added filter_data_rows() function that is called inside get_data_rows().
2) Added client_data_rows() function that is called inside get_data_rows(), if it exists or is defined in client files.

These are the pros and cons that I can think of:

Pros:
- As regards filter_data_rows() -- firstly, putting the filters inside get_data_rows() resolves this bug, but encapsulating it in a function means that changes to the browser filters don't have to replicated line by line in the client file.
- Similarly for client_data_rows(), this encapsulation means that changes to the base get_data_rows() code need not be replicated in the client file, and the client file can include only custom lines
- I find it helpful to conceptualize the retrieval of data rows into lms method call (get_data_rows()), utilities filtering (filter_data_rows()), and client customization (client_data_rows()), with all three functions customizable.

Cons:
- The use of two function calls instead of inline code can be considered an undesirable performance decrease
- filter_data_rows() may be considered superfluous, as custom filters can be added via client_data_rows(), and the code in filter_data_rows() can simply be inlined in get_data_rows().

What do you think? I only updated regbrowser.php, but this would apply to all browsers.

(0001043)
henry   
2009-10-29 13:00   
I've decided to get rid of filter_data_rows() and inline the filtering code inside get_data_rows(). I've done this because benefits of encapsulation in this particular case are minimal and considered not worth the performance decrease. Additional filters can be added via client_data_rows().
(0001044)
vcs   
2009-10-29 13:00   
issue#221 removed use of filter_data_rows() in the document browser


Repository: /var/svn/trellis-dev, Revision: 8799, Committer: henry
(0001048)
james   
2009-11-05 14:20   
Henry, please attach a patch so that we can review the process using the the client_data_rows() function.
(0001049)
henry   
2009-11-06 06:22   
A patch to regbrowser.php has been attached. The get_data_rows() function will work in the same manner for all browsers. Note that client_data_rows() allows you to return a dataset which get_data_rows() will then return. This is useful when you want to manipulate the dataset after receiving it from the lms->get() call.
(0001050)
james   
2009-11-12 15:34   
This looks useful using the client_data_rows() function, let's proceed with that.
(0001052)
vcs   
2009-11-13 16:22   
issue#221 completely removed the filter_data_rows() function and added support for client_data_rows() inside get_data_rows()


Repository: /var/svn/trellis-dev, Revision: 8804, Committer: henry
(0001055)
vcs   
2009-11-13 17:28   
issue#221 debugged for case when result set is an empty array


Repository: /var/svn/trellis-dev, Revision: 8805, Committer: henry
(0001070)
henry   
2009-12-14 10:51   
Reminder sent to: james
Moving the filters inside the get_data_rows() function resolves the issue of incorrect export row count. The addition of client_data_rows() provides encapsulation so that changes to get_data_rows() need not be updated in client files (which was the previous case), and client files can contain custom code only.

Both elements have been tested, are working and are ready for review.
(0001071)
vcs   
2009-12-14 15:07   
issue#221 removed filter_data_rows() and added client_data_rows() to documentcategories module


Repository: /var/svn/trellis-dev, Revision: 8833, Committer: henry
(0001072)
vcs   
2009-12-14 16:19   
issue#221 debugged for case when result set is an empty array in docbrowser module


Repository: /var/svn/trellis-dev, Revision: 8834, Committer: henry




Viewing Issue Advanced Details
220 [Trellis] Trellis Core/Base System feature N/A 2009-05-18 06:14 2010-05-13 16:47
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Add support in the core system for the Authoring Tool and Course Management
Add support in the core system for the Trellis Authoring Tool and Course Management. The authoring tool will reside within /core/author/.

the course info page will be revamped into a dashboard style page with:

    * course title
    * revision summary
    * list of managers
    * list of editors
    * list of who is currently editing the course
    * course log
    * learning objectives
    * issue summary
    * uploaded files
    * discussion notes
    * course tags

a new permission will be added, possibly "manage_courses" that allows an administrator assign managers and editors to courses. Assigned managers will also be able to assign editors to courses.

managers/editors will be able to check out courses in order to edit them, currently checked out courses will show up on the homepage as will a task list and in the future messages from the messaging system.

the resource library will consist of a global and course specific library with searching capabilities. They will be organized by type: image, video, flash, audio. there will be a preview pane that shows a thumbnail and/or meta data.

the authoring tool will use modular editing panes for different types of packages: text->word processor, test->test generator, etc.
Notes
(0000817)
vcs   
2009-05-18 06:24   
issue#220 added author directory structure and support in the request handler


Repository: /var/svn/trellis-dev, Revision: 8607, Committer: james
(0000821)
vcs   
2009-05-18 10:10   
issue#220 added is_course_developer to the users_communities table schema


Repository: /var/svn/trellis-dev, Revision: 8611, Committer: james
(0000822)
vcs   
2009-05-18 15:26   
issue#220 added author errors and updated permission to is_course_author


Repository: /var/svn/trellis-dev, Revision: 8612, Committer: james
(0000826)
vcs   
2009-05-18 15:44   
issue#220 updated get_mod function to support author path


Repository: /var/svn/trellis-dev, Revision: 8616, Committer: james
(0000827)
vcs   
2009-05-18 16:02   
issue#220 removed code from set_uri function accidentally committed


Repository: /var/svn/trellis-dev, Revision: 8617, Committer: james
(0000831)
vcs   
2009-05-18 16:43   
issue#220 added jquery ui for author interface functionality


Repository: /var/svn/trellis-dev, Revision: 8621, Committer: james
(0000841)
vcs   
2009-05-19 16:55   
issue#220 added author to new_class function


Repository: /var/svn/trellis-dev, Revision: 8627, Committer: james
(0000866)
vcs   
2009-06-01 15:48   
issue#220 added expandable course description fields


Repository: /var/svn/trellis-dev, Revision: 8639, Committer: james
(0000872)
vcs   
2009-06-02 06:53   
issue#220 added courses_contributors methods and database schema


Repository: /var/svn/trellis-dev, Revision: 8645, Committer: james
(0000873)
vcs   
2009-06-02 06:56   
issue#220 fixed get_course_contributors method database query


Repository: /var/svn/trellis-dev, Revision: 8646, Committer: james
(0000874)
vcs   
2009-06-02 07:00   
issue#220 fixed typos and database alias


Repository: /var/svn/trellis-dev, Revision: 8647, Committer: james
(0000875)
vcs   
2009-06-02 07:07   
issue#220 fixed typo


Repository: /var/svn/trellis-dev, Revision: 8648, Committer: james
(0000883)
vcs   
2009-06-03 02:08   
issue#220 use course_contributors table to check if user is permitted to author course


Repository: /var/svn/trellis-dev, Revision: 8652, Committer: james
(0000885)
vcs   
2009-06-03 02:12   
issue#220 debug is_course_author query, missing AND


Repository: /var/svn/trellis-dev, Revision: 8654, Committer: james
(0000900)
vcs   
2009-06-05 08:49   
issue#220 added an authoring method to the course object that will return html to create, edit and view the object in the authoring tool


Repository: /var/svn/trellis-dev, Revision: 8662, Committer: james
(0000922)
vcs   
2009-06-09 10:09   
issue#220 added authoring method to text object


Repository: /var/svn/trellis-dev, Revision: 8677, Committer: james
(0000931)
vcs   
2009-06-19 09:19   
issue#220 added authoring support to truefalse object


Repository: /var/svn/trellis-dev, Revision: 8688, Committer: james
(0000935)
vcs   
2009-06-22 09:34   
issue#220 updated course class to support authoring tool, updated authoring database tables


Repository: /var/svn/trellis-dev, Revision: 8693, Committer: james
(0000939)
vcs   
2009-06-25 06:25   
issue#220 added discussion for course management; added styling and package editing/fixes to author class


Repository: /var/svn/trellis-dev, Revision: 8697, Committer: james
(0000941)
vcs   
2009-06-25 07:32   
issue#220 added course management/discussion features to course info page


Repository: /var/svn/trellis-dev, Revision: 8699, Committer: james
(0000943)
vcs   
2009-06-25 07:33   
issue#220 hide course objective form


Repository: /var/svn/trellis-dev, Revision: 8701, Committer: james
(0000945)
vcs   
2009-06-25 12:01   
issue#220 updated preview course link


Repository: /var/svn/trellis-dev, Revision: 8703, Committer: james
(0000949)
vcs   
2009-07-02 05:53   
issue#220 added ability to define package types


Repository: /var/svn/trellis-dev, Revision: 8706, Committer: james
(0000950)
vcs   
2009-07-02 06:40   
issue#220 added add/edit/delete link icons


Repository: /var/svn/trellis-dev, Revision: 8707, Committer: james
(0000951)
vcs   
2009-07-02 07:23   
issue#220 updated styling


Repository: /var/svn/trellis-dev, Revision: 8708, Committer: james
(0000952)
vcs   
2009-07-02 08:38   
issue#220 delete object and package, preview course page


Repository: /var/svn/trellis-dev, Revision: 8709, Committer: james
(0000953)
vcs   
2009-07-02 08:50   
issue#220 added content to the text object when creating course


Repository: /var/svn/trellis-dev, Revision: 8710, Committer: james
(0000963)
vcs   
2009-07-24 02:33   
issue#220 added accreditor and course unit methods


Repository: /var/svn/trellis-dev, Revision: 8716, Committer: james
(0000965)
vcs   
2009-07-24 03:07   
issue#220 added order to course unit methods


Repository: /var/svn/trellis-dev, Revision: 8718, Committer: james
(0000970)
vcs   
2009-07-29 07:54   
issue#220 added trellis resource path constant and template support to parse constants in content


Repository: /var/svn/trellis-dev, Revision: 8720, Committer: james
(0000986)
vcs   
2009-08-28 08:42   
issue#220 fixed undefined variable


Repository: /var/svn/trellis-dev, Revision: 8735, Committer: james
(0000987)
vcs   
2009-08-28 09:26   
issue#220 debug typo


Repository: /var/svn/trellis-dev, Revision: 8736, Committer: james
(0001001)
vcs   
2009-09-15 06:16   
issue#220 fixed viewing of prerequisites and course development features on the course information page


Repository: /var/svn/trellis-dev, Revision: 8747, Committer: james
(0001042)
vcs   
2009-10-29 10:16   
issue#220 debugged error constant for TRELLIS_E_NOT_COURSE_AUTHOR


Repository: /var/svn/trellis-dev, Revision: 8798, Committer: henry
(0001114)
vcs   
2010-05-13 16:47   
issue#220 added parent_package_id to the author_packages table - Trellis Database Schema


Repository: /var/svn/trellis-dev, Revision: 8871, Committer: james




Viewing Issue Advanced Details
219 [Authoring Tool] Authoring Core/Base System minor have not tried 2009-05-18 06:11 2009-08-28 15:26
james  
james  
normal  
assigned  
open  
none    
none  
Create initial authoring core
Create a working initial core authoring system which includes functionality to build a book-type layout course as well as the interaction with the course objects.
Notes
(0000818)
vcs   
2009-05-18 09:06   
issue#219 add jquery.layout plugin to create the authoring tool interface


Repository: /var/svn/trellis-dev, Revision: 8608, Committer: james
(0000819)
vcs   
2009-05-18 09:48   
issue#219 added author default.tmpl


Repository: /var/svn/trellis-dev, Revision: 8609, Committer: james
(0000820)
vcs   
2009-05-18 09:58   
issue#219 added author global settings


Repository: /var/svn/trellis-dev, Revision: 8610, Committer: james
(0000823)
vcs   
2009-05-18 15:28   
issue#219 added course author access check


Repository: /var/svn/trellis-dev, Revision: 8613, Committer: james
(0000824)
vcs   
2009-05-18 15:36   
issue#219 added author login module and template


Repository: /var/svn/trellis-dev, Revision: 8614, Committer: james
(0000825)
vcs   
2009-05-18 15:38   
issue#219 added default author locations


Repository: /var/svn/trellis-dev, Revision: 8615, Committer: james
(0000829)
vcs   
2009-05-18 16:11   
issue#219 added action and task request variables


Repository: /var/svn/trellis-dev, Revision: 8619, Committer: james
(0000830)
vcs   
2009-05-18 16:12   
issue#219 insert html includes


Repository: /var/svn/trellis-dev, Revision: 8620, Committer: james
(0000832)
vcs   
2009-05-18 16:50   
issue#219 added initial author interface styling


Repository: /var/svn/trellis-dev, Revision: 8622, Committer: james
(0000833)
vcs   
2009-05-18 16:52   
issue#219 added jquery-ui


Repository: /var/svn/trellis-dev, Revision: 8623, Committer: james
(0000834)
vcs   
2009-05-18 17:02   
issue#219 added javascript to initialize author layout


Repository: /var/svn/trellis-dev, Revision: 8624, Committer: james
(0000840)
vcs   
2009-05-19 13:24   
issue#219 added home module


Repository: /var/svn/trellis-dev, Revision: 8626, Committer: james
(0000884)
vcs   
2009-06-03 02:10   
issue#219 added initial author class


Repository: /var/svn/trellis-dev, Revision: 8653, Committer: james
(0000897)
vcs   
2009-06-04 07:01   
issue#219 added basic authoring tool page layout


Repository: /var/svn/trellis-dev, Revision: 8660, Committer: james
(0000898)
vcs   
2009-06-04 07:03   
issue#219 added basic authoring tool page layout


Repository: /var/svn/trellis-dev, Revision: 8661, Committer: james
(0000901)
vcs   
2009-06-05 08:59   
issue#219 functionality updates to the authoring core


Repository: /var/svn/trellis-dev, Revision: 8663, Committer: james
(0000906)
vcs   
2009-06-05 16:37   
issue#219 updatwd some styling and core functionality


Repository: /var/svn/trellis-dev, Revision: 8665, Committer: james
(0000911)
vcs   
2009-06-05 22:50   
issue#219 updated more styling, optimized javascript, added content_panel module that returns html content via ajax


Repository: /var/svn/trellis-dev, Revision: 8668, Committer: james
(0000912)
vcs   
2009-06-05 22:59   
issue#219 author styling


Repository: /var/svn/trellis-dev, Revision: 8669, Committer: james
(0000913)
vcs   
2009-06-08 05:40   
issue#219 added author tables to database schema


Repository: /var/svn/trellis-dev, Revision: 8670, Committer: james
(0000914)
vcs   
2009-06-08 05:50   
issue#219 author front and backend optimizations, added tinymce editor for text objects


Repository: /var/svn/trellis-dev, Revision: 8671, Committer: james
(0000919)
vcs   
2009-06-09 05:04   
issue#219 more optimizations, ability to add packages and objects, new course object authoring method


Repository: /var/svn/trellis-dev, Revision: 8674, Committer: james
(0000920)
vcs   
2009-06-09 09:04   
issue#219 fixed class name from fill-in to math


Repository: /var/svn/trellis-dev, Revision: 8675, Committer: james
(0000921)
vcs   
2009-06-09 10:08   
issue#219 use tables to display object forms


Repository: /var/svn/trellis-dev, Revision: 8676, Committer: james
(0000923)
vcs   
2009-06-09 17:37   
issue#219 author optimizations and added page item editing


Repository: /var/svn/trellis-dev, Revision: 8678, Committer: james
(0000924)
vcs   
2009-06-09 17:40   
issue#219 fixed missing object code


Repository: /var/svn/trellis-dev, Revision: 8679, Committer: james
(0000925)
vcs   
2009-06-10 00:14   
issue#219 reload page when editing an item


Repository: /var/svn/trellis-dev, Revision: 8680, Committer: james
(0000929)
vcs   
2009-06-12 23:58   
issue#219 added base as template directories


Repository: /var/svn/trellis-dev, Revision: 8683, Committer: james
(0000932)
vcs   
2009-06-19 09:35   
issue#219 fix item parameters


Repository: /var/svn/trellis-dev, Revision: 8689, Committer: james
(0000933)
vcs   
2009-06-19 14:28   
issue#219 updated the way course objects are edited/created by allowing the object to create all of the form elements


Repository: /var/svn/trellis-dev, Revision: 8691, Committer: james
(0000934)
vcs   
2009-06-22 09:33   
issue#219 updated author core to reuse TrellisCourse class methods


Repository: /var/svn/trellis-dev, Revision: 8692, Committer: james
(0000940)
vcs   
2009-06-25 06:28   
issue#219 updated some course objects for authoring; adjusted classes to support authoring


Repository: /var/svn/trellis-dev, Revision: 8698, Committer: james
(0000954)
vcs   
2009-07-02 09:11   
issue#219 support course templates


Repository: /var/svn/trellis-dev, Revision: 8711, Committer: james
(0000955)
vcs   
2009-07-02 12:56   
issue#219 updated course contributor form and functionality


Repository: /var/svn/trellis-dev, Revision: 8712, Committer: james
(0000971)
vcs   
2009-07-29 09:08   
issue#219 added upload components to support resources


Repository: /var/svn/trellis-dev, Revision: 8721, Committer: james
(0000972)
vcs   
2009-07-29 09:10   
issue#219 debug


Repository: /var/svn/trellis-dev, Revision: 8722, Committer: james
(0000973)
vcs   
2009-07-29 09:15   
issue#219 debug


Repository: /var/svn/trellis-dev, Revision: 8723, Committer: james
(0000974)
vcs   
2009-07-29 10:54   
issue#219 added initial resource library


Repository: /var/svn/trellis-dev, Revision: 8724, Committer: james
(0000975)
vcs   
2009-07-29 11:26   
issue#219 added trellis resource path definition


Repository: /var/svn/trellis-dev, Revision: 8725, Committer: james
(0000976)
vcs   
2009-07-30 11:22   
issue#219 added authoring method


Repository: /var/svn/trellis-dev, Revision: 8726, Committer: james
(0000977)
vcs   
2009-07-30 11:31   
issue#219 added authoring method


Repository: /var/svn/trellis-dev, Revision: 8727, Committer: james
(0000985)
vcs   
2009-08-27 10:04   
issue#219 fixed additional bugs and added ordering of objects


Repository: /var/svn/trellis-dev, Revision: 8734, Committer: james
(0000988)
vcs   
2009-08-28 09:28   
issue#219 added button object to test packages


Repository: /var/svn/trellis-dev, Revision: 8737, Committer: james
(0000989)
vcs   
2009-08-28 14:49   
issue#219 added gallerycon plugin for tinymce and linked it to our resource library


Repository: /var/svn/trellis-dev, Revision: 8738, Committer: james
(0000990)
vcs   
2009-08-28 15:26   
issue#219 added course path uri


Repository: /var/svn/trellis-dev, Revision: 8739, Committer: james




Viewing Issue Advanced Details
218 [Trellis] Authentication/Security feature N/A 2009-05-15 12:26 2009-05-19 10:20
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
Allow a client setting to set the user_status of a user upon public learner registration
Currently, when going through the public learner registration process, the user_status is not defined, therefore it always defaults to inactive.

I propose a client setting that will set the value of user_status if it is not defined. This will take place in the create_user method of the TrellisLMS class.
It will check if user_status is set, if not, it will then check for the created_user_status client setting for the user_status value. If there is none define there, then it will default to invalid.
Notes
(0000815)
vcs   
2009-05-15 12:32   
issue#218 added created_user_status client setting and a check for the client setting value when creating a user


Repository: /var/svn/trellis-dev, Revision: 8605, Committer: james
(0000816)
vcs   
2009-05-15 12:53   
issue#218 set the user's learner permission to 1 when registering


Repository: /var/svn/trellis-dev, Revision: 8606, Committer: james
(0000838)
vcs   
2009-05-19 10:11   
issue#218 added created_user_status client setting and a check for the client setting value when creating a user and set the user's learner permission when registering


Repository: /var/svn/trellis, Revision: 119, Committer: james




Viewing Issue Advanced Details
217 [Trellis] Action Objects minor always 2009-04-24 16:44 2009-05-19 10:20
henry  
henry  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
error when trying to access this->db in action object
I have an action object and in one of its methods I try to call this->db->select_field() and receive the following error:

Fatal error: Call to a member function select_field() on a non-object in ...

Steps to reproduce:
1) In any Trellis action object, try to access a member of this->db
2) Receive the error

Although the TrellisActionObject class (from which all Trellis action objects are extended) has db as a property and sets it if it is passed $db as an argument in the constructor, it appears $db is not being passed. A look into the new_class() function in core_functions.php confirms that when an action object is created, $db is not passed.

My question is: should new_class() pass $db by default, or should the action object only set this->db (from global $db) if it needs to use it?
Notes
(0000810)
henry   
2009-04-24 16:50   
Because objects are always copied by reference in PHP5, I think we should pass $db by default as it doesn't represent any real memory cost. What do you think?
(0000811)
james   
2009-04-24 17:15   
yeah, let's pass $db by default
(0000812)
vcs   
2009-04-24 18:10   
issue#217

pass $db as a parameter to the constructor when creating a new Trellis action object


Repository: /var/svn/trellis-dev, Revision: 8604, Committer: henry
(0000813)
henry   
2009-04-24 18:15   
Reminder sent to: james
This has been completed, is working and is ready for review.
(0000839)
vcs   
2009-05-19 10:13   
issue#217 pass $db as a parameter to the constructor when creating a new Trellis action object


Repository: /var/svn/trellis, Revision: 120, Committer: james




Viewing Issue Advanced Details
216 [Trellis] Administration/Reports minor have not tried 2009-04-15 16:43 2009-04-16 02:12
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
add permissions to admin data table columns to prevent unaccessible linking
Some admin data tables, like the User Browser, should require a specific permission so that only users who have permission to view/access the information will be able to access the link.

One example of this is the User Browser data table and the Group column. If an admin does not have access to view the group information, then that link should not be used, only the value should be shown.

Notes
(0000796)
vcs   
2009-04-15 16:52   
issue#216 added required permissions to the group column


Repository: /var/svn/trellis-dev, Revision: 8596, Committer: james
(0000797)
james   
2009-04-15 17:16   
I updated this issue to apply to data table column links
(0000798)
vcs   
2009-04-15 17:25   
issue#216 added make_data_table ability to set a link_permission


Repository: /var/svn/trellis-dev, Revision: 8597, Committer: james
(0000799)
vcs   
2009-04-15 17:28   
issue#216 added link permissions to columns that link to other modules


Repository: /var/svn/trellis-dev, Revision: 8598, Committer: james
(0000803)
vcs   
2009-04-16 01:18   
issue#216 reverted make_data_table, functionality already exists to check/process link_permission


Repository: /var/svn/trellis-dev, Revision: 8599, Committer: james
(0000804)
vcs   
2009-04-16 02:12   
issue#216 added link permissions to data table links


Repository: /var/svn/trellis-dev, Revision: 8600, Committer: james




Viewing Issue Advanced Details
215 [Trellis] Trellis Core/Base System text N/A 2009-04-15 15:24 2009-04-15 17:44
henry  
henry  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
grammatical error/typo for TRELLIS_E_COURSE_NOT_EMPTY error message
The error message for TRELLIS_E_COURSE_NOT_EMPTY contains a grammatical error or typo. The word "remove" should be "removed".

"That course cannot be remove because dependencies still exist."

Should be:

"That course cannot be removed because dependencies still exist."
Notes
(0000793)
vcs   
2009-04-15 15:32   
issue#215

fixed grammatical errors for TRELLIS_E_COURSE_NOT_EMPTY and TRELLIS_E_MAX_ATTEMPTS


Repository: /var/svn/trellis-dev, Revision: 8594, Committer: henry
(0000794)
henry   
2009-04-15 15:33   
Note that I also changed "reach" to "reached" in the sentence "You have reach the maximum number of attempts allowed." for TRELLIS_E_MAX_ATTEMPTS.
(0000800)
vcs   
2009-04-15 17:43   
issue#215 resolved
fixed grammatical errors for TRELLIS_E_COURSE_NOT_EMPTY and TRELLIS_E_MAX_ATTEMPTS


Repository: /var/svn/trellis, Revision: 114, Committer: james




Viewing Issue Advanced Details
214 [Trellis] Administration/Reports major always 2009-04-09 15:11 2009-04-09 15:24
veasna  
 
normal  
new 0.5.2  
open  
none    
none  
User Passwords
This version of Trellis has encrypted users' passwords so that even admins are unable to view the passwords. This security feature presents a problem for admins who need to log in as a user to troubleshoot problems within that user's account. As is, there are only two options for an admin to log in as a user without knowing their password.

1. Ask the user for their password.
2. Reset the user's password to something generic like "123456" and then ask them to go back in and change it under "My Account" once the problem has been resolved.

My suggested solutions to the problem:
1. Develop a universal password only known and used by admins to get into users' accounts without having to know their actual password.
2. Create a permission setting that allows only certain admins to view users' passwords.
3. Create a special login page for admins (on a secured site where admins must first log in themselves) where they can log into any user's account using only the user's username without entering a password.

I'm not a developer/programmer, so obviously I know that my suggestions may not be possible without some major developing and technical magic.

Please feel free to make other suggestions w/o responding to mine.

Veasna
There are no notes attached to this issue.




Viewing Issue Advanced Details
213 [Trellis] Action Objects minor always 2009-04-08 15:58 2009-04-15 17:48
henry  
henry  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
radio buttons not working properly in action object
I have a custom action object which has several radio buttons from which the user can choose. No matter what radio button is selected by the user, the value is always set to the last radio button.

Steps to reproduce:
1) Find/create an action object which lets the user select from several radio buttons
2) Perform the action and note that no matter which radio button you select, it is always set to the value of the last radio button

Note: This applies to any form element in array form, which is to say it has several input elements each with the same name. For example, three input texts each with the name 'color[]'. The most common elements in array form are radio buttons and checkboxes.
Notes
(0000790)
henry   
2009-04-08 16:05   
(edited on: 2009-04-08 16:06)
This occurs because the way the form data is submitted. When you click the 'Perform' button, it calls the perform_action() function (located in core/global/resources/script/actions.js). This function cycles through each <input> element and creates a javascript object with the property name set to the input name and the property value set to the input value. Because radio buttons and checkboxes have several input elements with the same name, only the last iteration of an input element name will be recorded in the javascript object.

Please see line 221 in the actions.js file, in the perform_action() function.

(0000791)
vcs   
2009-04-13 15:41   
issue#213

- added form_data_to_object javascript function, which takes the data from a form and converts it into a javscript object
- updated perform_action function to utilize form_data_to_object


Repository: /var/svn/trellis-dev, Revision: 8593, Committer: henry
(0000792)
henry   
2009-04-13 17:20   
(edited on: 2009-04-13 17:21)
Reminder sent to: james
This has been tested, is working and is ready for review. Also, please let me know if you think of a better function name and/or would like changes to the syntax.

(0000801)
vcs   
2009-04-15 17:48   
issue#213 resolved
- added form_data_to_object javascript function, which takes the data from a form and converts it into a javscript object
- updated perform_action function to utilize form_data_to_object


Repository: /var/svn/trellis, Revision: 115, Committer: james




Viewing Issue Advanced Details
212 [Trellis] Administration/Reports feature N/A 2009-04-04 15:29 2009-04-15 17:51
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
allow .client files the ability to customize data table options
Give the ability to customize data table options for data tables. Currently the table options are defined and passed directly in the .snip file and there is no way to customize these options using a .client file.
There are no notes attached to this issue.




Viewing Issue Advanced Details
211 [Trellis] Administration/Reports feature N/A 2009-04-04 13:51 2009-04-16 02:15
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
add a row to data tables that return no results with a "No results" message
When a data table (i.e. user browser) has an empty result, the data table shows the header row (#, user id, username, etc), but no table rows after that. I'm requesting that a message be shown indicating there is no results. This message could be customized as well if necessary.
For this, the make_data_table function will be modified and a new key will be returned which contains the html when there is no result. The "No result" message will be able to be customized through the $table_options parameter
Notes
(0000789)
vcs   
2009-04-04 14:04   
issue#211 modified make_data_table function to generate a no results html row


Repository: /var/svn/trellis-dev, Revision: 8592, Committer: james
(0000795)
vcs   
2009-04-15 16:48   
issue#211 added the no result variable in the snip to use when no results are returned


Repository: /var/svn/trellis-dev, Revision: 8595, Committer: james
(0000805)
vcs   
2009-04-16 02:15   
issue#211 added the no result variable in the snip to use when no results are returned


Repository: /var/svn/trellis-dev, Revision: 8601, Committer: james




Viewing Issue Advanced Details
210 [Trellis] SCORM minor sometimes 2009-04-03 15:40 2009-04-03 15:43
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
Undefined variable: db when score_course is called
In the TrellisSCORM class, there is an unrecognized variable $db in the score_course method. This is preventing scoring the course in some cases.

The $db should be changed to $this->db
Notes
(0000780)
vcs   
2009-04-03 15:41   
issue#210 Undefined variable: db


Repository: /var/svn/trellis-dev, Revision: 8584, Committer: james
(0000781)
vcs   
2009-04-03 15:42   
issue#210 resolved
Undefined variable: db


Repository: /var/svn/trellis, Revision: 113, Committer: james




Viewing Issue Advanced Details
209 [Trellis] Certificates feature N/A 2009-03-31 16:18 2009-03-31 16:19
henry  
henry  
normal  
assigned 0.5.2  
open  
none    
none  
create certificate -- add feature to award the certificate to users who already meet the requirement
When a new certificate is created, an option to award the certificate to users who already meet the certificate's requirements would be useful. We could use a checkbox labeled "Retroactively award certificate" or something similar, with the default having the checkbox checked.
There are no notes attached to this issue.




Viewing Issue Advanced Details
208 [Trellis] Learning Center minor N/A 2009-03-25 13:52 2009-04-15 17:50
henry  
henry  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
auto-register when self_course_registration is set to true
My learning center has the setting self_course_registration set to true. But when I click 'Launch' on the courseinfo page (for a course I'm not regsitered in), I receive an error that I am not registered in the course.

If self_course_registration is set to true, it should auto-register me in the course instead of giving me an error.
Notes
(0000775)
vcs   
2009-03-25 14:11   
issue#208

auto-register user in course if he's not already registered and self_course_registration is set to true


Repository: /var/svn/trellis-dev, Revision: 8580, Committer: henry
(0000776)
henry   
2009-03-25 14:12   
Reminder sent to: james
This has been tested, is working and is ready for review.
(0000802)
vcs   
2009-04-15 17:50   
issue#208 resolved
auto-register user in course if he's not already registered and self_course_registration is set to true


Repository: /var/svn/trellis, Revision: 116, Committer: james




Viewing Issue Advanced Details
207 [Trellis] Trellis Core/Base System minor have not tried 2009-03-20 19:53 2009-03-20 20:19
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
user's program is checked for completeness and is incomplete, remove the completion date
When a user's program is checked for completeness, currently the user_program_status is set to incomplete. The completion_date is not changed. For programs that may have been previously completed, this is an issue because the user's program could result in an incomplete status with a completion date.

This could also lead to issue when issuing a certificate which a program is a requirement for.
The check_program_completion should be adjusted to set the completion_date to 0000-00-00 00:00:00 when it find the program to be incomplete.
Notes
(0000773)
vcs   
2009-03-20 19:54   
issue#207 zero out the completion date to when checking for a user's program completion and the program is incomplete


Repository: /var/svn/trellis-dev, Revision: 8579, Committer: james
(0000774)
vcs   
2009-03-20 20:19   
issue#207 resolved
zero out the completion date to when checking for a user's program completion and the program is incomplete


Repository: /var/svn/trellis, Revision: 112, Committer: james




Viewing Issue Advanced Details
206 [Trellis] Certificates minor always 2009-03-20 13:27 2009-03-20 13:32
james  
james  
normal  
resolution committed 0.5.2  
fixed  
none    
none  
Query error when updating a certificate's expiration date
I received an error when a certificate that the user already had was awarded to the user and in turn extended the expiration date of the certificate. Here's the query error I received:

Example error produced:
SteamDB->query(UPDATE users_certificates SET expiration_date = '2014-03-20 13:22:10' WHERE user_id = '1604' certificate_id '3'): the query could not be completed; You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'certificate_id '3'' at line 1; /var/www/trellis/0.5/core/global/classes/SteamDB_to_TrellisDB.php @ line 186;

It looks like the culprit is a missing AND and = in the query statement on line 1113 of the TrellisCourse class.
Notes
(0000771)
vcs   
2009-03-20 13:30   
issue#206 fixed query error in check_certificate_completion method


Repository: /var/svn/trellis-dev, Revision: 8578, Committer: james
(0000772)
vcs   
2009-03-20 13:32   
issue#206 resolved
fixed query error in check_certificate_completion method


Repository: /var/svn/trellis, Revision: 111, Committer: james




Viewing Issue Advanced Details
205 [Trellis] Administration/Reports minor always 2009-03-12 14:17 2009-03-16 11:02
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
autocomplete inputs should only return items from the current community
Autocomplete input fields should only return items (courses, programs, users, etc) specific to the current community and not all items.

For example:
When setting up a program, the admin needs to add courses to it.
Using the autocomplete form, all courses in the system appear when typing starts. It should only return courses that are part of that community and not all courses.

This requires that the quick_search method is updated to only return items from the current community.
Notes
(0000759)
vcs   
2009-03-12 14:18   
issue#205 only return courses from the current community via the autocomplete form


Repository: /var/svn/trellis-dev, Revision: 8571, Committer: james
(0000766)
james   
2009-03-16 11:02   
issue has been updated to globally fix all items returned by auto-complete input fields.




Viewing Issue Advanced Details
204 [Trellis] Trellis Core/Base System minor always 2009-03-12 13:43 2009-03-12 13:50
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
create_registration method issue with courses in a program and course expiration dates
When creating a registration for a user in a program, the create_registration method get's all the non-expired and active/inactive/staging courses so that it can register the user into them.

The way it is retrieving these courses though is incorrect. It gets the courses that have no expiration date AND their expiration date is in the future OR their status is active, inactive or staging.

What it is expected to do is:
get the courses that have no expiration date or their expiration date is in the future AND the course status is active, inactive or staging.
Notes
(0000757)
vcs   
2009-03-12 13:47   
issue#204 updated create_registration method to correctly grab all valid courses in a program


Repository: /var/svn/trellis-dev, Revision: 8570, Committer: james
(0000758)
james   
2009-03-12 13:50   
this has been tested and is available for review




Viewing Issue Advanced Details
203 [Trellis] Events feature N/A 2009-03-11 21:57 2009-04-04 12:12
james  
james  
normal  
assigned 0.5.2  
open  
none    
none  
Add event browser/info pages to System Settings in Trellis Admin
Allow admins with the proper permissions to view/edit events from the admin site. This will consist of 2 modules:
- event browser (shows all events, their info and their statuses)
- event info (shows a specifc event's details and allows editing the event information if scheduled run date is in the future)

New permissions will be required to access these modules:
view_event_browser
view_event_info
edit_event_info

The event browser will be accessible from the System Settings menu.
Notes
(0000746)
vcs   
2009-03-11 21:59   
issue#203 added blank eventbrowser module
added new permissions to db schema: view_event_browser, view_event_info, edit_event_info
added Event Browser to System Settings menu


Repository: /var/svn/trellis-dev, Revision: 8560, Committer: james
(0000747)
vcs   
2009-03-11 22:00   
issue#203 edited menu item to say Browse Events


Repository: /var/svn/trellis-dev, Revision: 8561, Committer: james
(0000787)
vcs   
2009-04-04 12:11   
issue#203 added initial eventbrowser module


Repository: /var/svn/trellis-dev, Revision: 8590, Committer: james
(0000788)
vcs   
2009-04-04 12:12   
issue#203 fixed date issue when calling get_events


Repository: /var/svn/trellis-dev, Revision: 8591, Committer: james




Viewing Issue Advanced Details
202 [Trellis] Action Objects feature N/A 2009-03-11 17:15 2009-03-11 17:34
henry  
 
normal  
confirmed 0.5.2  
duplicate  
none    
none  
restrict access to actions/actions objects through use of permissions
I want to restrict access to action objects for an administrator group. Currently there is no way to do so. I suggest to allow each action object the option of requiring a permission to access it, defaulting to allow access if no permission specified.

This applies to the course browser, registration browser, user browser and user program browser (and possibly course section browser, but currently that module does not utilize bulk actions).
Notes
(0000741)
james   
2009-03-11 17:18   
I believe this is a duplicate of 0000166, please view that issue and the discussion that towards a solution




Viewing Issue Advanced Details
201 [Trellis] General/Other minor always 2009-03-11 15:50 2010-05-26 08:08
carlos  
carlos  
normal  
confirmed 0.5.0  
open  
none    
none  
No option to add "reply_to" in the send_email() function
I am working on a Plugin and I need to add the reply_to option in order to have the recipient of the email respond to the user I need them to respond to.

I suggest to add this under line 559 on core_functions.php:

   if (isset($options['reply_to']))
    {
        $email_reply_to = array_merge($email_reply_to, $options['reply_to']);
    }
    foreach ($email_reply_to as $address => $name)
    {
        $email->AddReplyTo($address, $name);
    }
Notes
(0000761)
carlos   
2009-03-13 07:48   
I realized when you add this option, the old templates would give us the "$email_reply_to not defined" error. What we could do is add a condition to create an empty array if it is not defined. That way we avoid having to add the variable to all of the templates.

    if (!isset($email_reply_to)
    {
       $email_reply_to = array();
    }

    if (isset($options['reply_to']))
    {
        $email_reply_to = array_merge($email_reply_to, $options['reply_to']);
    }
    if(!empty($email_reply_to))
    {
        foreach ($email_reply_to as $address => $name)
        {
            $email->AddReplyTo($address, $name);
        }
    }
(0000762)
james   
2009-03-13 08:54   
Okay that will work.
(0000764)
vcs   
2009-03-13 10:30   
issue#201 Suggested code has been added in order to have the option of setting the "reply_to" value.


Repository: /var/svn/trellis-dev, Revision: 8574, Committer: carlos
(0000852)
carlos   
2009-05-28 12:26   
Reminder sent to: james
I believe this could be marked as resolved too. The patch is already applied and it seems to be working fine.
(0001116)
carlos   
2010-05-23 09:34   
I am going to mark this as resolved since it has been committed and working fine.



Viewing Issue Advanced Details
200 [Trellis] Administration/Reports feature N/A 2009-03-10 13:15 2009-04-17 18:04
henry  
henry  
normal  
resolution committed 0.5.2